feat: add balance formatting across the app #321
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r1b2ns
changed the title
|
screenshots of this look great, will review code today, pumped! |
|
Tested, what you have looks and works great and the code fits in nicely with the codebase. I think my only ask would be to apply the balance format to 2 more screens:
So no code changes needed on current code, but just if you can add the way you are applying balance formatting to 2 additional views. |
Awesome, I’ll do this this evening. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This solves #307 by applying balance formatting across the app.
Screen
Home Screen
Transactions Screen
Notes to the reviewers
Changelog notice
Checklists
All Submissions:
.swift-formatfileNew Features:
I've added tests for the new featureI've added docs for the new feature